Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Stopping with repeat #140

Merged
merged 2 commits into from
Jan 7, 2023
Merged

Fixes Stopping with repeat #140

merged 2 commits into from
Jan 7, 2023

Conversation

jrincayc
Copy link
Owner

@jrincayc jrincayc commented Jan 6, 2023

Closes #137

@dmalec
Copy link
Collaborator

dmalec commented Jan 6, 2023

This change looks good to me:

  • The code to address the value of stopping_flag being out of sync is nicely commented.
  • The unit tests appear to cover known cases and are structured in a way that is straightforward to follow.

👍

@jrincayc jrincayc changed the title Adding tests for proper stopping. Fixes Stopping with repeat Jan 6, 2023
@dmalec
Copy link
Collaborator

dmalec commented Jan 7, 2023

Reviewed and approve.

@dmalec dmalec merged commit 64fc46e into master Jan 7, 2023
@jrincayc jrincayc deleted the issue_137 branch January 8, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[STOP] quit the superprocedure when inside [REPEAT]
2 participants
@jrincayc @dmalec