Skip to content

Commit

Permalink
replacing rounded faraday constant with exact value in bpx.py (pybamm…
Browse files Browse the repository at this point in the history
…-team#4290)

* updated faraday constant to exact value in bpx.py

* Update CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>

* Update CHANGELOG.md

* Update pybamm/parameters/bpx.py

Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>

* Update CHANGELOG.md

Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>

---------

Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>
Co-authored-by: Arjun Verma <arjunverma.oc@gmail.com>
  • Loading branch information
4 people authored and js1tr3 committed Aug 12, 2024
1 parent 6946072 commit c038d22
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pybamm/parameters/bpx.py
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ def _entropic_change(sto, c_s_max, dUdT, constant=False):
# (cs-cs_max)) in BPX exchange current is defined j0 = F * k_norm * sqrt((ce/ce0) *
# (cs/cs_max) * (1-cs/cs_max))
c_e = pybamm_dict["Initial concentration in electrolyte [mol.m-3]"]
F = 96485
F = pybamm.constants.F.value

def _exchange_current_density(c_e, c_s_surf, c_s_max, T, k_ref, Ea):
return (
Expand Down

0 comments on commit c038d22

Please sign in to comment.