undefined min/max in StreamTerminators.h for msvc #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
while working on Windows and compiling with MSVC(1921), and using common windows headers, i couldn't compile while using Streams. This is due to the implementation of
and
in
StreamTerminators.h
.min
andmax
are already defined as macrosand
in
minwindef.h
.I got it working by first, undefining, and at the end of the file, redefining
min
andmax
.