Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change origin getter result for file: URLs to "null" #117

Closed
TimothyGu opened this issue Jul 25, 2018 · 3 comments
Closed

Change origin getter result for file: URLs to "null" #117

TimothyGu opened this issue Jul 25, 2018 · 3 comments
Assignees

Comments

@TimothyGu
Copy link
Member

https://url.spec.whatwg.org/#concept-url-origin says:

A URL’s origin is the origin returned by running these steps, switching on URL’s scheme:

"file"
Unfortunate as it is, this is left as an exercise to the reader. When in doubt, return a new opaque origin.
@TimothyGu
Copy link
Member Author

case "file":
// spec says "exercise to the reader", chrome says "file://"
return "file://";

@TimothyGu
Copy link
Member Author

See also nodejs/node#21955

@domenic
Copy link
Member

domenic commented Aug 2, 2018

+1 on this, although it may be a major version bump since it changes the same-originness of file URLs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants