Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves #794 #802

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

nikhilkalburgi
Copy link

GitHub Issue: #794

Summary:

I have created a workflow that checks if the issue contains the original template every Monday 10min before the meeting. If there is any agenda added to it by the issue-collector workflow, then the condition does not match else a comment is sent to the issue thread along with slack notification like it is done for few other workflows.

This does not close the issue itself. Let me know if this works and you also want me to automate closing the issue.

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this PR! Much appreciated. I just added a few suggestions but looks great ...

REPO: 'community'
OCWM_LABEL: ${{ vars.OCWM_LABEL }}
TEMPLATE_PATH: '../ISSUE_TEMPLATE/open_community_working_meeting.md'
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK_GEN_NOTIF }}

This is the secret containing the the webhook


on:
schedule:
- cron: '50 21 * * 1' # Runs at 21:50 UTC, which is 10 minutes before 14:00 PT every Monday
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- cron: '50 21 * * 1' # Runs at 21:50 UTC, which is 10 minutes before 14:00 PT every Monday
- cron: '50 18 15-21 * 1' # Runs at 11:50 AM PT on the 3rd Monday of the month

I am suggesting this change because we just decided to make the meetings mothly the 3rd monday of the month and 2 hours earlier as 12:00 PT


// Add a comment to the issue
await mygithub.request(`POST /repos/${process.env.OWNER}/${process.env.REPO}/issues/${latestIssue.number}/comments`, {
body: "The meeting as been cancelled as there is no agenda for today. Thanks"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
body: "The meeting as been cancelled as there is no agenda for today. Thanks"
body: "The meeting has been cancelled as there is no agenda for today. Thanks everyone!"


// Send a notification to Slack
const slackPayload = {
text: `The meeting as been cancelled as there is no agenda for today. Thanks`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
text: `The meeting as been cancelled as there is no agenda for today. Thanks`
text: `The meeting has been cancelled as there is no agenda for today. Thanks everyone!`

@nikhilkalburgi
Copy link
Author

Hi @benjagm,

I've made the changes that were suggested to the workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants