Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] version settings: Allow react defaultVersion to be configurable #3771

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

onlywei
Copy link
Contributor

@onlywei onlywei commented Jun 20, 2024

I have some projects where I want to detect the react version most of the time, but sometimes I expect that to fail. In those cases, I don't want to default to "latest". I instead want to choose the default fallback version of React.

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.76%. Comparing base (cef8123) to head (79a6496).
Report is 2 commits behind head on master.

Files Patch % Lines
lib/util/version.js 96.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3771      +/-   ##
==========================================
+ Coverage   97.62%   97.76%   +0.13%     
==========================================
  Files         134      134              
  Lines        9617     9644      +27     
  Branches     3488     3497       +9     
==========================================
+ Hits         9389     9428      +39     
+ Misses        228      216      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems pretty solid, thanks. I'm going to hold off on merging semver-minor PRs for a bit, but I'll make sure to get to it before i make the next release.

@ljharb ljharb force-pushed the master branch 2 times, most recently from 380e32c to 51d342b Compare July 4, 2024 15:25
@ljharb ljharb force-pushed the default-version branch 2 times, most recently from 418374f to 00b89fe Compare July 15, 2024 22:51
@ljharb ljharb changed the title Allow react defaultVersion to be configurable [New] version settings: Allow react defaultVersion to be configurable Jul 15, 2024
@ljharb ljharb merged commit 00b89fe into jsx-eslint:master Jul 16, 2024
343 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants