Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] jsx-handler-names: support ignoring component names #3772

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

akulsr0
Copy link
Contributor

@akulsr0 akulsr0 commented Jun 21, 2024

Closes #3722

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.63%. Comparing base (b747450) to head (1625b1a).

Current head 1625b1a differs from pull request most recent head 58c9063

Please upload reports for the commit 58c9063 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3772      +/-   ##
==========================================
+ Coverage   97.51%   97.63%   +0.11%     
==========================================
  Files         134      134              
  Lines        9625     9631       +6     
  Branches     3494     3496       +2     
==========================================
+ Hits         9386     9403      +17     
+ Misses        239      228      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ljharb ljharb changed the title [Fix] jsx-handler-names: support ignoring component names [New] jsx-handler-names: support ignoring component names Jun 25, 2024
@ljharb ljharb force-pushed the master branch 2 times, most recently from 380e32c to 51d342b Compare July 4, 2024 15:25
@akulsr0
Copy link
Contributor Author

akulsr0 commented Jul 11, 2024

Bump up

docs/rules/jsx-handler-names.md Outdated Show resolved Hide resolved
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks. I'm going to hold off landing semver-minors for a little bit, but the next one will include this PR.

tests/lib/rules/jsx-handler-names.js Outdated Show resolved Hide resolved
tests/lib/rules/jsx-handler-names.js Outdated Show resolved Hide resolved
@ljharb ljharb merged commit 6a83d67 into jsx-eslint:master Jul 15, 2024
343 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

jsx-handler-names support skipping prop naming checks
2 participants