[Fix] destructuring-assignment: fix false negative when using typeof props.a
#3835
+112
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of props.a` Fixes jsx-eslint#3828 Co-authored-by: Chiawen Chen <golopot@gmail.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
ljharb
reviewed
Sep 30, 2024
golopot
force-pushed
the
issue-3828
branch
2 times, most recently
from
3cf37dc
to
76025ba
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3835 +/- ##
==========================================
- Coverage 97.69% 93.66% -4.03%
==========================================
Files 136 133 -3
Lines 9958 9957 -1
Branches 3688 3693 +5
==========================================
- Hits 9728 9326 -402
- Misses 230 631 +401
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ljharb
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3828
The rule failed to catch usages of
typeof props.abecause it is parsed a TSQualifiedName instead of a memberExpression.