Fix metric export data for unused gauges (open-telemetry#1363)

jtescher · Nov 13, 2023 · f6fb7a6 · f6fb7a6
1 parent a3a5283
commit f6fb7a6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/opentelemetry-sdk/CHANGELOG.md b/opentelemetry-sdk/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## vNext
 
+### Fixed
+
+- Fix metric export corruption if gauges have not received a last value. (#1363)
+
 ## v0.21.0
 
 ### Added

diff --git a/opentelemetry-sdk/src/metrics/internal/last_value.rs b/opentelemetry-sdk/src/metrics/internal/last_value.rs
@@ -55,8 +55,12 @@ impl<T: Number<T>> LastValue<T> {
     pub(crate) fn compute_aggregation(&self, dest: &mut Vec<DataPoint<T>>) {
         let mut values = match self.values.lock() {
             Ok(guard) if !guard.is_empty() => guard,
-            _ => return,
+            _ => {
+                dest.clear(); // poisoned or no values recorded yet
+                return;
+            }
         };
+
         let n = values.len();
         if n > dest.capacity() {
             dest.reserve(n - dest.capacity());