[JENKINS-73849] Adding token and SSL verification disabling check for FIPS #1
+206
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the Google OAuth library which is in maintainance mode with a supported library (nimbusds via pac4j) The library requires that the Issuer is set to enforce security and there is no option to disable this requirement as it is mandated in the specificiation. As such users must first update to 4.355.v3a_fb_fca_b_96d4 to set the Issuer before updating to this version. fixes: jenkinsci#313
src/test/java/org/jenkinsci/plugins/oic/OicSecurityRealmFipsTest.java
Outdated
Show resolved
Hide resolved
This changes the Google OAuth library which is in maintainance mode with a supported library (nimbusds via pac4j) The library requires that the Issuer is set to enforce security and there is no option to disable this requirement as it is mandated in the specificiation. As such users must first update to 4.355.v3a_fb_fca_b_96d4 to set the Issuer before updating to this version. fixes: jenkinsci#313
jtnord
force-pushed
the
pac4j
branch
7 times, most recently
from
b6041de
to
60fc090
Compare
jtnord
reviewed
Oct 8, 2024
jtnord
reviewed
Oct 8, 2024
jtnord
reviewed
Oct 8, 2024
src/main/java/org/jenkinsci/plugins/oic/OicServerManualConfiguration.java
Outdated
Show resolved
Hide resolved
Comment on lines
2
to
4
| The Client secret used by jenkins to authenticate itself to the openid connect provider. | ||
| Special value "none" can be used to disable client secret (only with client_secret_post authentication). | ||
| The Subject Idendifier Type to use as part of the flow with the openid connect provider. | ||
| This must be supported by the IdP. | ||
| Valid values are <code>public</code> and <code>pairwise</code>. |
There was a problem hiding this comment.
I think this PR is out of date with the target branch (or incorrect merge has been performed?)
src/test/java/org/jenkinsci/plugins/oic/OicSecurityRealmFipsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/jenkinsci/plugins/oic/OicSecurityRealmFipsTest.java
Outdated
Show resolved
Hide resolved
fcojfernandez
approved these changes
Oct 9, 2024
6 tasks
Co-authored-by: Francisco Javier Fernandez <31063239+fcojfernandez@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When in FIPs mode SSL and token verificaiton can not be disabled.
This change adds a form validation that will warn the user, fails with an
IllegalArgumentExceptionif trying to save regardless the warning and checks values onreadResolve, in case config file was manually modified.Testing done
Added 3 tests and checked manually.