Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More build script fixes and tweaks #9

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

More build script fixes and tweaks #9

wants to merge 1 commit into from

Conversation

DilumAluthge
Copy link
Member

  1. Explicitly use Bash, instead of worrying about being compatible with any shell.
  2. Use ${foo:?} whenever possible, to make sure that variables are defined and not empty.
  3. At the beginning of the script, make sure all dependencies exist, before we start running any commands.

Also includes the macOS sed fix from #8.

@DilumAluthge
Copy link
Member Author

Bump @IanButterworth

@IanButterworth
Copy link
Member

Go for it, if you've tested this

@DilumAluthge
Copy link
Member Author

I need to do some more testing. For now, I'll cut setup-julia@2.3.0 off of your #8 branch.

@DilumAluthge DilumAluthge marked this pull request as draft July 21, 2024 21:33
@DilumAluthge DilumAluthge removed the request for review from IanButterworth July 21, 2024 21:33
@DilumAluthge DilumAluthge changed the title More build script fixes More build script fixes and tweaks Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DilumAluthge @IanButterworth