Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trace() throws UndefVarError; (not documented) tr() should be used instead #319

Closed
kmundnic opened this issue Aug 24, 2019 · 4 comments · Fixed by #327
Closed

trace() throws UndefVarError; (not documented) tr() should be used instead #319

kmundnic opened this issue Aug 24, 2019 · 4 comments · Fixed by #327
Labels
documentation good first issue help wanted

Comments

@kmundnic
Copy link

I'm using Convex v0.12.4. The (stable) docs say that trace is implemented, and the examples use trace. However, using it throws an error.

The source code suggests that tr is implemented instead, in src/atoms/affine/trace.jl.

It seems like the documentation needs to include this update.
@ericphanson
Copy link
Collaborator

Thanks for the report! Agreed

ericphanson added a commit that referenced this issue Sep 9, 2019
@ericphanson
Fix #319
d64e2a4
@ericphanson ericphanson mentioned this issue Sep 9, 2019
Merged
ericphanson added a commit that referenced this issue Sep 9, 2019
@ericphanson
Fix #319 (#327)
0a46d84
@RoyiAvital
Copy link

I still don't see any tr() or trace() in https://jump.dev/Convex.jl/stable/operations/.

@ericphanson
Copy link
Collaborator

it's there, no?
Screenshot 2023-11-25 at 15 13 41

@RoyiAvital
Copy link

Silly me, I did a search for trace assuming it will be written next to it.
Sorry...

@ericphanson ericphanson mentioned this issue Nov 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation good first issue help wanted
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[docs] Update trace to tr jump-dev/Convex.jl
3 participants
@kmundnic @ericphanson @RoyiAvital