Fix and simplify partial trace, add more tests #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
reviewed
May 6, 2019
|
Looks good overall. Would you be willing to add some |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The partial trace was implemented using just
kron,*, andsum, which are already atoms, so we actually don’t needPartialTraceAtom. Additionally,evaluateandconic_form!were implemented separately but via the same algorithm (and the version inevaluatewas incorrect), so I’ve replaced it all with a generic function following the same method. I also fixed the test (to see why the new version of the test is right, note the solution to the SDP should satisfy the constraint), and added some additional tests.Fixes #281.