Rearrange exports; deprecate lambdamin
, lambdamax
#357
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm thinking about the API we should expose in Convex.jl v0.13 (see #346), and realized it's hard to know what API we expose now, since the exports are scattered across files.
I've therefore moved them all to the top of
src/Convex.jl
. I also unexported many functions that I feel should be internal:+
instead ofAdditionAtom
)Base.to_index
,promote_size
,get_row
,conic_form!
,Value
,ValueOrNothing
, which just don't seem to need to be exportedI have left the re-exports from LinearAlgebra, though maybe we should revisit that (maybe a user should need to do
using LinearAlgebra
in order to get e.g.norm
andeigmin
).I also deprecated
lambdamin
andlambdamax
in favor ofLinearAlgebra.eigmin
andLinearAlgebra.eigmax
, which closes #336.