Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variety of fixes to the docs #484

Merged
merged 7 commits into from
Mar 2, 2022
Merged

Variety of fixes to the docs #484

merged 7 commits into from
Mar 2, 2022

Conversation

odow
Copy link
Member

@odow odow commented Mar 2, 2022

  • Tidy make.jl
  • Enforce strict=true so failing docs not ignored
  • Use silent_solver where possible
  • Change repl blocks to example

Closes #483, but still running locally so there might be some failures.

odow and others added 6 commits March 2, 2022 13:43
 * Tidy make.jl
 * Enforce strict=true so failing docs not ignored
 * Use silent_solver where possible
 * Change repl blocks to example
@ericphanson
Copy link
Collaborator

ericphanson commented Mar 2, 2022

I think we should add silent_solver=true to the Lasso example: https://jump.dev/Convex.jl/previews/PR484/examples/general_examples/lasso_regression/. It didn't print that much before, not sure why it does now (but maybe it was a bug and Documenter wasn't catching all the output before). Took a brief look at the other examples and they looked fine.

@odow odow merged commit 61af7c5 into master Mar 2, 2022
@odow odow deleted the od/fix-docs branch March 2, 2022 02:14
@odow
Copy link
Member Author

odow commented Mar 2, 2022

@ericphanson any objections to me tagging a v0.15 release?

@ericphanson
Copy link
Collaborator

Nope, fine by me! Thanks for all this great maintenance work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Fix the docs
2 participants