remove deprecated AbstractTrees calls #494
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've recently done a major overhaul of AbstractTrees.jl which will be part of the upcoming v0.4 release for that package. Convex.jl is unique in that it is the only registered dependency of AbstractTrees.jl which uses the soon-to-be-deprecated functions
treekind
andIndexedTree
.It seems that Convex.jl contains a re-implementation of
print_tree
because of a problem that dates back to AbstractTrees.jl v0.2. At first, I completely removed this re-implementation in favor of the current AbstractTrees implementation, but later realized that it has since diverged fromAbstractTrees.print_tree
even in v0.3. In particular, whilemaxdepth
has worked fine for a while, we do not have amaxwidth
. There are also some small differences in the exact printed forms.Instead, I've removed the calls to
treekind
andIndexedTree
. This should be fine for all versions of AbstractTree.jl because these features were very poorly documented and almost never used (which has now been explicitly verified).