Tidy src/atoms/affine #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #538 +/- ##
==========================================
- Coverage 92.83% 92.73% -0.11%
==========================================
Files 86 86
Lines 5375 5310 -65
==========================================
- Hits 4990 4924 -66
- Misses 385 386 +1 ☔ View full report in Codecov by Sentry. |
odow
commented
Jan 10, 2024
| end | ||
|
|
||
| head(io::IO, ::ImaginaryAtom) = print(io, "imag") | ||
|
|
||
| function Base.sign(x::ImaginaryAtom) | ||
| # FIXME(odow): what is this? | ||
| sign(x.children[1]) == ComplexSign() |
There was a problem hiding this comment.
Follow up later: I don't think this method is correct because this statement isn't used.
Closed
blegat
reviewed
Jan 10, 2024
| # add_subtract.jl | ||
| # Handles unary negation, addition and subtraction of variables, constants | ||
| # and expressions. | ||
| # All expressions and atoms are subtpyes of AbstractExpr. |
There was a problem hiding this comment.
Is this not useful or has it be moved somewhere ?
There was a problem hiding this comment.
I didn't think it was useful. It's pretty obvious that NegateAtom handles negation. And we really need a docstring for each atom with examples, rather than this vague comment in the file. But that's a separate PR...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some small formatting changes, mainly so I have an excuse to read through and understand the code.