Add license headers #606
Add license headers #606
Conversation
| and .travis.yml contain code copied from the Transducers.jl package | ||
| (https://github.com/tkf/Transducers.jl/) which is licensed under the MIT License: | ||
|
|
||
| >Copyright (c) 2018 Takafumi Arakaki |
There was a problem hiding this comment.
I've moved this to a separate LICENSE.md file in benchmark. It isn't part of the Convex.jl source code that gets loaded by using Convex.
|
|
||
| The `TreePrint` module contains code from the AbstractTrees.jl package | ||
| (https://github.com/Keno/AbstractTrees.jl) which is licensed under the | ||
| MIT "Expat" License: |
There was a problem hiding this comment.
I've moved this to the file src/utilities/tree_prinnt.jl
| >AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| >LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| >OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| >SOFTWARE. |
There was a problem hiding this comment.
It's not really obvious that code like:
# This file was copied from Transducers.jl
# which is available under an MIT license (see LICENSE).
using PkgBenchmark
benchmarkpkg(
dirname(@__DIR__),
BenchmarkConfig(env = Dict("JULIA_NUM_THREADS" => "1")),
resultfile = joinpath(@__DIR__, "result.json"),is justified to declare the MIT license. This is just usage of a package, unrelated to Transducers?
| @@ -1,5 +1,7 @@ | |||
| # Some code in `src/problem_depot` was modified from MathOptInterface | |||
| # which is available under an MIT license (see LICENSE). | |||
There was a problem hiding this comment.
I've removed the reference to MathOptInterface's MOI. Looking through this file, I don't see anything that justifies it. I don't think using a constant to store a benchmark suite justifies it.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #606 +/- ##
=======================================
Coverage 97.83% 97.83%
=======================================
Files 86 86
Lines 5035 5035
=======================================
Hits 4926 4926
Misses 109 109 ☔ View full report in Codecov by Sentry. |
|
I think I was probably too conservative with license stuff, added too many. This looks good! |
I'll comment in-line with a few things.