-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize ExpAtom
#613
Closed
Closed
optimize ExpAtom
#613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #613 +/- ##
==========================================
+ Coverage 97.83% 97.88% +0.04%
==========================================
Files 88 88
Lines 5045 5058 +13
==========================================
+ Hits 4936 4951 +15
+ Misses 109 107 -2 ☔ View full report in Codecov by Sentry. |
ericphanson
commented
May 4, 2024
ericphanson
commented
May 4, 2024
ericphanson
commented
May 4, 2024
Closed
ericphanson
commented
May 4, 2024
Closing in favor of #618 |
57 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #254
Before: on the original problem, today I OOM'd on my 16 GB macbook pro. On previous attempts, I got
On this branch:
The issue is formulating 33378 IndexAtoms and so forth. In general in Convex we must never do scalar operations if we hope to formulate things performantly (unless we move everything to a scalar representation like MOI).
Here, I couldn't see how to avoid the scalar operations, so I lower to MOI to do them on that level, which is efficient.
I filed #614 to track this issue more generally.