Improve performance of QolElemAtom #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #620 +/- ##
=======================================
Coverage 97.88% 97.88%
=======================================
Files 88 88
Lines 5062 5068 +6
=======================================
+ Hits 4955 4961 +6
Misses 107 107 ☔ View full report in Codecov by Sentry. |
ericphanson
reviewed
May 5, 2024
| @@ -21,6 +21,8 @@ function MOI.output_dimension(v::VectorAffineFunctionAsMatrix) | |||
| return size(v.matrix, 1) | |||
| end | |||
|
|
|||
| to_vaf(tape::SPARSE_VECTOR) = tape | |||
There was a problem hiding this comment.
I've wanted this also, but I skipped it since vaf was supposed to mean VectorAffineFunction. Maybe we can do this + rename it?
There was a problem hiding this comment.
I'm going to leave this hack for now, and rename it in a separate PR. to_vaf is really _to_vector_moi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x-ref #614