WIP: add 2d convolution reformulation #635
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #376
It is just a reformulation and doesn't need any Convex.jl internals, but it is not super obvious how to do it (a direct scalar loopy approach would be terribly slow), and we support 1D convolutions so it seems like it is within scope.
I still need to write tests. Also it's not clear if this should just be a method to
convor a separate function. Adding a method definitely feels more Julian, but since we have the "treat everything like a matrix" matlab thing, I'd worry a little there could be weird interactions there.