Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename GenericConstraint into Constraint and remove abstract type #665

Merged
merged 6 commits into from
May 15, 2024

Conversation

blegat
Copy link
Member

@blegat blegat commented May 15, 2024

This is the last breaking change I'd like to make until v0.16

@odow
Copy link
Member

odow commented May 15, 2024

So this has the potential to be quite breaking. Is anyone writing new constraints in the wild?

@ericphanson
Copy link
Collaborator

I think it is unlikely; I just checked the 12 registered packages that use Convex.jl (via https://juliahub.com/ui/Packages/General/Convex), and none of them seem to. Also, I don't think it was ever documented how to construct a new Constraint type.

@odow
Copy link
Member

odow commented May 15, 2024

Okay, then I'm 👍 for this

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.04%. Comparing base (8ad02eb) to head (d268e90).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #665      +/-   ##
==========================================
+ Coverage   97.94%   98.04%   +0.09%     
==========================================
  Files          89       89              
  Lines        5165     5160       -5     
==========================================
  Hits         5059     5059              
+ Misses        106      101       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow odow merged commit 30825a2 into master May 15, 2024
10 checks passed
@odow odow deleted the bl/gen_con branch May 15, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants