Support vector sets in MOI wrapper #669
Conversation
| ::Type{MOI.ScalarNonlinearFunction}, | ||
| ::Type{<:Union{MOI.EqualTo{T},MOI.GreaterThan{T},MOI.LessThan{T}}}, | ||
| ::Type{MOI.VectorNonlinearFunction}, | ||
| ::Type{<:MOI.AbstractVectorSet}, |
There was a problem hiding this comment.
We should probably have a list of sets for which we define vexity instead because otherwise, if there is a set for which vexity is not defined but there is a bridge to convert it into sets for which vexity is defined, it won't be applied because Convex lied saying that vexity is defined
There was a problem hiding this comment.
We'll say true, and then end up calling a missing vexity and get "`Convex.vexity(vex, ::$(typeof(set)))`: is not yet implemented. Please open an issue at https://github.com/jump-dev/Convex.jl", so that seems like an okay error. It tells them to open an issue, at least.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #669 +/- ##
==========================================
+ Coverage 98.04% 98.09% +0.05%
==========================================
Files 89 89
Lines 5160 5150 -10
==========================================
- Hits 5059 5052 -7
+ Misses 101 98 -3 ☔ View full report in Codecov by Sentry. |
Second option of the two options listed in #668
Closes #668