Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate silent_solver to silent #670

Merged
merged 9 commits into from
May 19, 2024
Merged

Deprecate silent_solver to silent #670

merged 9 commits into from
May 19, 2024

Conversation

ericphanson
Copy link
Collaborator

Since now it is being used for Convex's verbosity also (printing the formulation time). It is also shorter which I like. I also set it to turn off the warning for non-optimal solutions for consistency and to reduce clutter in test logs.

@ericphanson ericphanson requested a review from odow May 17, 2024 15:29
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.11%. Comparing base (d19955e) to head (2c6937e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #670      +/-   ##
==========================================
+ Coverage   98.09%   98.11%   +0.02%     
==========================================
  Files          89       89              
  Lines        5150     5157       +7     
==========================================
+ Hits         5052     5060       +8     
+ Misses         98       97       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericphanson
Copy link
Collaborator Author

IMO it would be good for this to be part of v0.16.0 to reduce churn. But it isn’t breaking so it could go in after.

@ericphanson ericphanson added this to the v0.16.0 milestone May 17, 2024
src/solution.jl Outdated Show resolved Hide resolved
src/solution.jl Outdated Show resolved Hide resolved
test/test_utilities.jl Outdated Show resolved Hide resolved
test/test_utilities.jl Outdated Show resolved Hide resolved
src/solution.jl Outdated Show resolved Hide resolved
@odow odow merged commit ecc91cd into master May 19, 2024
10 checks passed
@odow odow deleted the eph/deprecate-silent-solver branch May 19, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants