-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate silent_solver
to silent
#670
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #670 +/- ##
==========================================
+ Coverage 98.09% 98.11% +0.02%
==========================================
Files 89 89
Lines 5150 5157 +7
==========================================
+ Hits 5052 5060 +8
+ Misses 98 97 -1 ☔ View full report in Codecov by Sentry. |
IMO it would be good for this to be part of v0.16.0 to reduce churn. But it isn’t breaking so it could go in after. |
odow
reviewed
May 19, 2024
odow
reviewed
May 19, 2024
odow
reviewed
May 19, 2024
odow
reviewed
May 19, 2024
odow
reviewed
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since now it is being used for Convex's verbosity also (printing the formulation time). It is also shorter which I like. I also set it to turn off the warning for non-optimal solutions for consistency and to reduce clutter in test logs.