Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dims argument to LogSumExpAtom #692

Merged
merged 5 commits into from
May 27, 2024
Merged

Add dims argument to LogSumExpAtom #692

merged 5 commits into from
May 27, 2024

Conversation

odow
Copy link
Member

@odow odow commented May 27, 2024

Closes #682
Closes #685

@odow odow requested a review from ericphanson May 27, 2024 08:09
@odow
Copy link
Member Author

odow commented May 27, 2024

So perhaps the simplest thing is just if we add a ; dims argument to relevant of atoms.

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.21%. Comparing base (7a8c0df) to head (bae4c9a).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #692      +/-   ##
==========================================
+ Coverage   98.20%   98.21%   +0.01%     
==========================================
  Files          89       89              
  Lines        5168     5198      +30     
==========================================
+ Hits         5075     5105      +30     
  Misses         93       93              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ericphanson ericphanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, nice and simple. I think it would be worth carrying over the tests in src/problem_depot/problems/exp.jl from the other PR

src/atoms/LogSumExpAtom.jl Outdated Show resolved Hide resolved
@odow odow merged commit 459f86b into master May 27, 2024
10 checks passed
@odow odow deleted the od/LogSumExp branch May 27, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Scalar indexing in logisticloss
2 participants