Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated releaser workflows available at 9fdfe52 #58

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Update releaser workflows from official GitHub repository

@fcollonval fcollonval added the enhancement New feature or request label Jan 5, 2024
@fcollonval fcollonval closed this Jan 5, 2024
@fcollonval fcollonval reopened this Jan 5, 2024
@fcollonval fcollonval merged commit 1333077 into main Jan 5, 2024
24 checks passed
@fcollonval fcollonval deleted the new-releaser-workflows-9fdfe52 branch January 5, 2024 16:58
@jtpio
Copy link
Member

jtpio commented Jan 5, 2024

Do we want to show this silent option to all extension authors creating an extension from the template? (even if it's commented)

Thinking this could be extra noise to most extension authors, as this feature was mostly meant for making security releases for core Jupyter projects if I recall correctly?

@fcollonval
Copy link
Member

I don't like to hide feature to the end user. At least like that they are aware something is available.

Otherwise, we should update the upstream example. As having auto sync for those workflow is great to reduce maintenance burden.

@jtpio
Copy link
Member

jtpio commented Jan 5, 2024

Otherwise, we should update the upstream example. As having auto sync for those workflow is great to reduce maintenance burden.

Yeah maybe that can be a solution too. And/or mentioning the silent option in RELEASE.md?

Thinking about some feedback some extension authors had about the cookiecutters / templates growing in complexity over time, and how we could try to mitigate that (for instance jupyterlab/extension-cookiecutter-js#36).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants