Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Licence does not show in deb installer #357

Open
krassowski opened this issue Dec 3, 2021 · 2 comments
Open

Licence does not show in deb installer #357

krassowski opened this issue Dec 3, 2021 · 2 comments
Labels

Comments

@krassowski
Copy link
Member

Description

The licence in the deb installer shows up as proprietary:

Screenshot from 2021-12-03 16-08-02

Reproduce

Open the .deb file on Ubuntu 21.10

Expected behavior

BSD-3-Clause License should be shown

Context

GitHub does not show the licence too:

Screenshot from 2021-12-03 16-13-53

compare to RetroLab:

Screenshot from 2021-12-03 16-14-15

This could be due to a fragment copied over from core which we do not actually have in the repository:

https://github.com/jupyterlab/jupyterlab-desktop/pull/191/files/a7d8295f3702faf56d2b1c1106afd0e3fe51eab8#diff-c693279643b8cd5d248172d9c22cb7cf4ed163a3c98c8a3f69c2717edd3eacb7

as discussed in #191 (comment) we should remove it

@krassowski krassowski added the bug label Dec 3, 2021
@krassowski
Copy link
Member Author

@krassowski
Copy link
Member Author

Thanks to #360 the license is now detected on GitHub:

Screenshot from 2021-12-04 21-43-32

The .deb installer issue is upstream, but we can keep it open for informative purposes (so that it is clear to users).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant