Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to JupyterLab 3 #191

Merged
merged 23 commits into from
Sep 13, 2021
Merged

Upgrade to JupyterLab 3 #191

merged 23 commits into from
Sep 13, 2021

Conversation

mbektas
Copy link
Member

@mbektas mbektas commented Mar 20, 2021

  • Upgrades to JupyterLab 3.1.10 version
  • MVP solution for stand-alone and self-contained desktop application for macOS, Debian, Ubuntu, Red Hat, Fedora and Windows with GUI installers for each platform
  • Bundles JupyterLab server using conda constructor and automatically installs the conda environment during app installation. Following conda packages are included in the environment:
  - python 3.8
  - numpy
  - scipy
  - pandas
  - jupyterlab 3.1.10
  - ipywidgets 7.6.4
  - matplotlib
  • Some features are removed (remote JupyterLab server connection etc) for now with the initial goal being providing an MVP desktop app

macOS
jlab-mac-install

jlab-mac

Ubuntu
jlab-ubuntu-install

jlab-ubuntu

Fedora
jlab-fedora-install

jlab-fedora

Windows
jlab-windows-install

jlab-windows

@mbektas mbektas changed the title Upgrade to recent jupyterlab, lumino and electron Upgrade to JupyterLab 3 Mar 20, 2021
@mbektas
Copy link
Member Author

mbektas commented Mar 24, 2021

Current state:
jlab desktop app

@ellisonbg
Copy link
Contributor

This is awesome! Somewhere we have the account, certificates, and information needed to create the app for MacOS. Let me know if you want to dive into that and I can track down the needed information.

@mbektas
Copy link
Member Author

mbektas commented Mar 24, 2021

This is awesome! Somewhere we have the account, certificates, and information needed to create the app for MacOS. Let me know if you want to dive into that and I can track down the needed information.

Thanks @ellisonbg ! Sure, please share that information with me. Not so urgent but I will need those.

@echarles
Copy link
Member

Are the instructions on the README still valid to test this PR?

@mbektas
Copy link
Member Author

mbektas commented Mar 25, 2021

Are the instructions on the README still valid to test this PR?

Yes @echarles, yarn commands work for me. I didn't update & test distribution build yet. Are you having any issues?

yarn install and yarn build:all should work fine

@echarles
Copy link
Member

@mbektasbbg No issue, yarn and yarn build:all work fine on my env and the electron window is launched correctly.

I am on mac, and confused with To build for macOS a macOS computer is required.: There is no yarn dockerdist:macostarget.

Then there is If you don't want to user Docker but instead want to build locally, there are a few dependencies you're required to install.: On https://github.com/electron-userland/electron-builder I read To ensure your native dependencies are always matched electron version, simply add script "postinstall": "electron-builder install-app-deps" to your package.json.. What should I do? (As you see, first-time electron developer here).

@mbektas
Copy link
Member Author

mbektas commented Mar 25, 2021

I am on mac, and confused with To build for macOS a macOS computer is required.: There is no yarn dockerdist:macostarget.

@echarles readme seems to be pretty outdated. Once I update distribution related code, I will make sure readme is up to date as well.

@echarles
Copy link
Member

Thx a lot @mbektasbbg for working on this. Looking forward the instructions when you will publish them.

@fperez
Copy link

fperez commented Mar 26, 2021

Thx so much @mbektasbbg for this work!! Just yesterday I was discussing this app with @lgfunderburk, in the context of her work at Cybera/Callysto. For some of her use cases, a standalone, self-contained, "native" app would be very valuable. I missed your recent work on it, so it's great to see it moving forward!

@mbektas
Copy link
Member Author

mbektas commented Mar 27, 2021

Thx so much @mbektasbbg for this work!! Just yesterday I was discussing this app with @lgfunderburk,

Thanks @fperez! Yes, our goal is to provide a self-contained native app which would also be able to connect to remote Jupyter server backends.

@mbektas
Copy link
Member Author

mbektas commented Sep 7, 2021

Thx a lot @mbektasbbg for working on this. Looking forward the instructions when you will publish them.

@echarles you can now follow the updated instructions to create a Mac installer and test. Now we have a self-contained app with its own conda env. bundled in. More updates to follow.

@mbektas mbektas marked this pull request as ready for review September 13, 2021 04:31
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Happy to merge and iterate, but let's leave this open for a day in case anyone else has feedback

@blink1073
Copy link
Contributor

The yarn file has a conflict

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks @mbektas for the update!

@jtpio
Copy link
Member

jtpio commented Sep 13, 2021

Given that this is clearly a big improvement compared to the current state on master, we can indeed go ahead with a merge and iterate 👍

@blink1073 blink1073 merged commit f653b93 into jupyterlab:master Sep 13, 2021
@welcome
Copy link

welcome bot commented Sep 13, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Comment on lines +29 to +33
Semver File License
===================

The semver.py file is from https://github.com/podhmo/python-semver
which is licensed under the "MIT" license. See the semver.py file for details.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krassowski I copied the LICENSE file as is from jupyterlab repo. I just checked, semver.py is shipped with bundled jupyterlab python package. but I am not sure if it is OK to remove from jupyterlab-desktop license.

@blink1073
Copy link
Contributor

but I am not sure if it is OK to remove from jupyterlab-desktop license

I'd say it is OK to remove, since that file was never explicitly included in this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants