[Backport to 3.3.x] Fix the debug modules model #11967 #11968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
|
CI is green, this is ready to merge. |
|
Did CI checks really run here? This is how it looks for me:
There is the old azure check showing up for some reason (we saw this randomly in a few places) but no JS tests. |
|
Closing/Opening to relaunch CI |
|
@krassowski I have relaunched and it is green. This can be merged. |
|
@fcollonval Will be great if you could look at this to get it for the proposed 3.3. alpha this week I have mentioned on #11643 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #11967
We need to respect the debug modules https://microsoft.github.io/debug-adapter-protocol/specification#Requests_Modules
This PR updates the layout of the returned JSON (reply on the modules request) to respect the spec.
Also remove commented code.