chore: replaced ESLint & Prettier with Biome, reformatted the project…

…, added lint & format check to pipeline
jurerotar · May 15, 2024 · cc35b0a · cc35b0a
1 parent 35c34df
commit cc35b0a
Show file tree

Hide file tree

Showing 171 changed files with 1,112 additions and 3,699 deletions.
diff --git a/.eslintrc b/.eslintrc
diff --git a/.github/workflows/develop-ci.yml b/.github/workflows/develop-ci.yml
@@ -27,5 +27,11 @@ jobs:
       - name: Type check
         run: npm run type-check
 
+      - name: Lint
+        run: npm run lint:check
+
+      - name: Format
+        run: npm run format:check
+
       - name: Run tests
         run: npm test
diff --git a/.github/workflows/master-ci.yml b/.github/workflows/master-ci.yml
@@ -27,5 +27,11 @@ jobs:
       - name: Type check
         run: npm run type-check
 
+      - name: Lint
+        run: npm run lint:check
+
+      - name: Format
+        run: npm run format:check
+
       - name: Run tests
         run: npm test
diff --git a/.github/workflows/other-branches-ci.yml b/.github/workflows/other-branches-ci.yml
@@ -28,5 +28,11 @@ jobs:
       - name: Type check
         run: npm run type-check
 
+      - name: Lint
+        run: npm run lint:check
+
+      - name: Format
+        run: npm run format:check
+
       - name: Run tests
         run: npm test
diff --git a/.prettierignore b/.prettierignore
diff --git a/__mocks__/game/game-environment.ts b/__mocks__/game/game-environment.ts
@@ -1,36 +1,36 @@
 import { QueryClient } from '@tanstack/react-query';
+import { mapFiltersCacheKey } from 'app/[game]/[map]/hooks/use-map-filters';
 import { achievementsCacheKey } from 'app/[game]/hooks/use-achievements';
+import { currentServerCacheKey } from 'app/[game]/hooks/use-current-server';
 import { effectsCacheKey } from 'app/[game]/hooks/use-effects';
 import { eventsCacheKey } from 'app/[game]/hooks/use-events';
 import { heroCacheKey } from 'app/[game]/hooks/use-hero';
 import { mapCacheKey } from 'app/[game]/hooks/use-map';
+import { playersCacheKey } from 'app/[game]/hooks/use-players';
 import { questsCacheKey } from 'app/[game]/hooks/use-quests';
 import { reportsCacheKey } from 'app/[game]/hooks/use-reports';
+import { reputationsCacheKey } from 'app/[game]/hooks/use-reputations';
 import { researchLevelsCacheKey } from 'app/[game]/hooks/use-research-levels';
 import { villagesCacheKey } from 'app/[game]/hooks/use-villages';
-import { currentServerCacheKey } from 'app/[game]/hooks/use-current-server';
-import { Achievement } from 'interfaces/models/game/achievement';
-import { Village } from 'interfaces/models/game/village';
-import { Effect } from 'interfaces/models/game/effect';
-import { Hero } from 'interfaces/models/game/hero';
-import { Tile } from 'interfaces/models/game/tile';
-import { Quest } from 'interfaces/models/game/quest';
-import { ResearchLevel } from 'interfaces/models/game/research-level';
-import { Server } from 'interfaces/models/game/server';
-import { GameEvent } from 'interfaces/models/events/game-event';
-import { Report } from 'interfaces/models/game/report';
-import { serverMock } from 'mocks/models/game/server-mock';
-import { Player } from 'interfaces/models/game/player';
-import { playersCacheKey } from 'app/[game]/hooks/use-players';
-import { Reputation } from 'interfaces/models/game/reputation';
-import { reputationsCacheKey } from 'app/[game]/hooks/use-reputations';
-import { mapFiltersCacheKey } from 'app/[game]/[map]/hooks/use-map-filters';
-import { MapFilters } from 'interfaces/models/game/map-filters';
-import { mapFiltersMock } from 'mocks/game/map-filters-mock';
+import type { GameEvent } from 'interfaces/models/events/game-event';
+import type { Achievement } from 'interfaces/models/game/achievement';
+import type { Effect } from 'interfaces/models/game/effect';
+import type { Hero } from 'interfaces/models/game/hero';
+import type { MapFilters } from 'interfaces/models/game/map-filters';
+import type { Player } from 'interfaces/models/game/player';
+import type { Quest } from 'interfaces/models/game/quest';
+import type { Report } from 'interfaces/models/game/report';
+import type { Reputation } from 'interfaces/models/game/reputation';
+import type { ResearchLevel } from 'interfaces/models/game/research-level';
+import type { Server } from 'interfaces/models/game/server';
+import type { Tile } from 'interfaces/models/game/tile';
+import type { Village } from 'interfaces/models/game/village';
 import { heroMock } from 'mocks/game/hero-mock';
-import { reputationsMock } from 'mocks/game/reputations-mock';
+import { mapFiltersMock } from 'mocks/game/map-filters-mock';
 import { playersMock } from 'mocks/game/players-mock';
+import { reputationsMock } from 'mocks/game/reputations-mock';
 import { villagesMock } from 'mocks/game/villages-mock';
+import { serverMock } from 'mocks/models/game/server-mock';
 
 const { id: serverId, slug } = serverMock;
 

diff --git a/__mocks__/game/hero-mock.ts b/__mocks__/game/hero-mock.ts
@@ -1,4 +1,4 @@
-import { Hero } from 'interfaces/models/game/hero';
+import type { Hero } from 'interfaces/models/game/hero';
 import { serverMock } from 'mocks/models/game/server-mock';
 
 const { id: serverId } = serverMock;

diff --git a/__mocks__/game/map-filters-mock.ts b/__mocks__/game/map-filters-mock.ts
@@ -1,5 +1,5 @@
+import type { MapFilters } from 'interfaces/models/game/map-filters';
 import { serverMock } from 'mocks/models/game/server-mock';
-import { MapFilters } from 'interfaces/models/game/map-filters';
 
 const { id: serverId } = serverMock;
 

diff --git a/__mocks__/game/players-mock.ts b/__mocks__/game/players-mock.ts
@@ -1,4 +1,4 @@
-import { Player } from 'interfaces/models/game/player';
+import type { Player } from 'interfaces/models/game/player';
 import { playerMock } from 'mocks/models/game/player-mock';
 
 export const playersMock: Player[] = [playerMock];
diff --git a/__mocks__/game/reputations-mock.ts b/__mocks__/game/reputations-mock.ts
@@ -1,4 +1,4 @@
-import { Reputation } from 'interfaces/models/game/reputation';
+import type { Reputation } from 'interfaces/models/game/reputation';
 import { npcReputationMock, playerReputationMock } from 'mocks/models/game/reputation-mock';
 
 export const reputationsMock: Reputation[] = [

diff --git a/__mocks__/game/villages-mock.ts b/__mocks__/game/villages-mock.ts
@@ -1,4 +1,4 @@
-import { Village } from 'interfaces/models/game/village';
+import type { Village } from 'interfaces/models/game/village';
 import { villageMock } from 'mocks/models/game/village/village-mock';
 
 export const villagesMock: Village[] = [villageMock];
diff --git a/__mocks__/models/game/event-mock.ts b/__mocks__/models/game/event-mock.ts
@@ -1,7 +1,7 @@
-import { GameEvent, GameEventType } from 'interfaces/models/events/game-event';
-import { villageMock } from 'mocks/models/game/village/village-mock';
-import { serverMock } from 'mocks/models/game/server-mock';
 import { getBuildingData } from 'app/[game]/utils/common';
+import { type GameEvent, GameEventType } from 'interfaces/models/events/game-event';
+import { serverMock } from 'mocks/models/game/server-mock';
+import { villageMock } from 'mocks/models/game/village/village-mock';
 
 const cranny = getBuildingData('CRANNY');
 

diff --git a/__mocks__/models/game/player-mock.ts b/__mocks__/models/game/player-mock.ts
@@ -1,4 +1,4 @@
-import { Player } from 'interfaces/models/game/player';
+import type { Player } from 'interfaces/models/game/player';
 
 export const playerMock: Player = {
   id: '42c53448-ab04-4ae3-8ce5-dccad55162a7',

diff --git a/__mocks__/models/game/reputation-mock.ts b/__mocks__/models/game/reputation-mock.ts
@@ -1,5 +1,5 @@
+import type { Reputation } from 'interfaces/models/game/reputation';
 import { serverMock } from 'mocks/models/game/server-mock';
-import { Reputation } from 'interfaces/models/game/reputation';
 
 export const playerReputationMock: Reputation = {
   serverId: serverMock.id,

diff --git a/__mocks__/models/game/server-mock.ts b/__mocks__/models/game/server-mock.ts
@@ -1,4 +1,4 @@
-import { Server } from 'interfaces/models/game/server';
+import type { Server } from 'interfaces/models/game/server';
 
 export const serverMock: Server = {
   seed: '23223ca711',

diff --git a/__mocks__/models/game/village/building-fields-mock.ts b/__mocks__/models/game/village/building-fields-mock.ts
@@ -1,4 +1,4 @@
-import { BuildingField } from 'interfaces/models/game/village';
+import type { BuildingField } from 'interfaces/models/game/village';
 
 export const newVillageBuildingFieldsMock: BuildingField[] = [
   {

diff --git a/__mocks__/models/game/village/resource-fields-mock.ts b/__mocks__/models/game/village/resource-fields-mock.ts
@@ -1,4 +1,4 @@
-import { BuildingField } from 'interfaces/models/game/village';
+import type { BuildingField } from 'interfaces/models/game/village';
 
 export const resourceFields00018Mock: BuildingField[] = [
   {

diff --git a/__mocks__/models/game/village/village-mock.ts b/__mocks__/models/game/village/village-mock.ts
@@ -1,8 +1,8 @@
-import { Village } from 'interfaces/models/game/village';
-import { serverMock } from 'mocks/models/game/server-mock';
+import type { Village } from 'interfaces/models/game/village';
 import { playerMock } from 'mocks/models/game/player-mock';
-import { resourceFields4446Mock } from './resource-fields-mock';
+import { serverMock } from 'mocks/models/game/server-mock';
 import { newVillageBuildingFieldsMock } from './building-fields-mock';
+import { resourceFields4446Mock } from './resource-fields-mock';
 
 const { id: serverId } = serverMock;
 const { id: playerId } = playerMock;

diff --git a/biome.json b/biome.json
@@ -0,0 +1,41 @@
+{
+  "$schema": "https://biomejs.dev/schemas/1.7.3/schema.json",
+  "formatter": {
+    "enabled": true,
+    "formatWithErrors": false,
+    "indentStyle": "space",
+    "indentWidth": 2,
+    "lineEnding": "lf",
+    "lineWidth": 140,
+    "attributePosition": "multiline",
+    "ignore": ["./build", "./coverage", "./dist", "./out", "./public", "./.husky", "./.github", "./docs"]
+  },
+  "organizeImports": { "enabled": true },
+  "linter": {
+    "enabled": true,
+    "rules": {
+      "recommended": true,
+      "correctness": {
+        "noUnusedVariables": "error"
+      },
+      "style": {
+        "noNonNullAssertion": "off"
+      }
+    },
+    "ignore": ["*.js", "*.json", "node_modules/"]
+  },
+  "javascript": {
+    "formatter": {
+      "jsxQuoteStyle": "double",
+      "quoteProperties": "asNeeded",
+      "trailingComma": "es5",
+      "semicolons": "always",
+      "arrowParentheses": "always",
+      "bracketSpacing": true,
+      "bracketSameLine": false,
+      "quoteStyle": "single",
+      "attributePosition": "multiline"
+    }
+  },
+  "overrides": [{ "include": ["*.config.ts"], "linter": { "rules": {} } }]
+}