Basic type definitions #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 5, 2024 10:56
typedef based on usage only see lib/gen.js to form proper typedef
missing lib/<module>.d.ts typedefs
downside - marked as readonly const object
billywhizz
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced
jsconfigwithtsconfig(was unable to remove external garbage types from @types/node in jsconfig)Added types for
lo,lo.coreis not fully typed,lib/<module>not typed at allChanged
lo initto use that working tsconfig and README.md as quick start guide for initialized projectAdded type hints for api definitions in
lib/<module>api.jsusing typed passthrough function (types are based on current usage samples, not on consumer of those objects). Should help editor with string literal hints when we add new lib definitions