Add additional explicit typing to plugin class.

justinkambic · Apr 27, 2020 · 93e421c · 93e421c
1 parent 1c42cc8
commit 93e421c
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/x-pack/plugins/uptime/public/apps/plugin.ts b/x-pack/plugins/uptime/public/apps/plugin.ts
@@ -30,9 +30,12 @@ export interface ClientPluginsStart {
 }
 
 export class UptimePlugin implements Plugin<void, void, ClientPluginsSetup, ClientPluginsStart> {
-  constructor(context: PluginInitializerContext) {}
+  constructor(_context: PluginInitializerContext) {}
 
-  public async setup(core: CoreSetup<ClientPluginsStart, unknown>, plugins: ClientPluginsSetup) {
+  public async setup(
+    core: CoreSetup<ClientPluginsStart, unknown>,
+    plugins: ClientPluginsSetup
+  ): Promise<void> {
     if (plugins.home) {
       plugins.home.featureCatalogue.register({
         id: PLUGIN.ID,
@@ -65,5 +68,5 @@ export class UptimePlugin implements Plugin<void, void, ClientPluginsSetup, Clie
 
   public start(_start: CoreStart, _plugins: {}): void {}
 
-  public stop() {}
+  public stop(): void {}
 }