Validation Tests

[f3l1x98]

This adds the missing validation tests for

• RangeLiteral
• RegexLiteral
• JayveeModel
• PropertyAssignment
• TransformBody
• TransformOutputAssignment
• TypedConstraintDefinition
• ValuetypeDefinition
• ExpressionConstraintDefinition

[felix-oq]

As a first comment, consider using lower-case letters for the input / output ports of transforms. That way the test models follow the naming convention established by the electric-vehicles.jv example.

[f3l1x98]

I have one question:
When exactly is the linking done?
Is it done separately or during parse, because if I use

valuetype ValueType oftype text {
  constraints: [
    Test
  ];
}

valuetype Test oftype text {
  constraints: [];
}

as input for the valuetype-definition test that tests

jayvee/libs/language-server/src/lib/validation/checks/valuetype-definition.ts

Line 81 in 9c908c2

validationContext.accept(

the test never "throws" the error as expected.
The reason for that is, that during the type-inference of the collection values expression?.value?.ref (more precise ref) in inferTypeFromReferenceLiteral is undefined, which from my understanding can either mean that linking has not been done, or the linking failed.

[felix-oq]

Awesome, well done!

[felix-oq]

I think you actually found a bug here. It message is supposed to state The pipeline name "Pipeline" needs to be unique.

Same for transforms, valuetypes and constraints.

[georg-schwarz]

Do you want to directly fix the bug? :)

[f3l1x98]

@georg-schwarz not sure if you mean me, but if yes I would do that in a separate PR and create an issue for that 😄

[felix-oq]

I have one question:
When exactly is the linking done?

...

The reason for that is, that during the type-inference of the collection values expression?.value?.ref (more precise ref) in inferTypeFromReferenceLiteral is undefined, which from my understanding can either mean that linking has not been done, or the linking failed.

The linking is done during the creation of the LangiumDocument, see here for more details. The reason, it does not link in your case is that valuetypes are not referencable in expressions due to the grammar (except for valuetype assignments). You can have a look at it in expression.langium. So the linker does not even attempt perform the linking in this case because it is considered illegal.

[f3l1x98]

I have one question:
When exactly is the linking done?
...
The reason for that is, that during the type-inference of the collection values expression?.value?.ref (more precise ref) in inferTypeFromReferenceLiteral is undefined, which from my understanding can either mean that linking has not been done, or the linking failed.

The linking is done during the creation of the LangiumDocument, see here for more details. The reason, it does not link in your case is that valuetypes are not referencable in expressions due to the grammar (except for valuetype assignments). You can have a look at it in expression.langium. So the linker does not even attempt perform the linking in this case because it is considered illegal.

I understand, forgot to check whether the grammar considers this valid.
Thank you 👍

[georg-schwarz]

Please make sure to follow the jest naming pattern for consistency. I added one example.

describe should always point to the subject under test (the class or broader functionality). It is a test file, so no need to mention it is a test.

it should always start with a "should" defining the expected behavior, potentially followed by a "when" later to distinguish different preconditions.

[georg-schwarz]

Love it, well done!