Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test logger cache refactor #455

Merged
merged 6 commits into from
Oct 16, 2023
Merged

Test logger cache refactor #455

merged 6 commits into from
Oct 16, 2023

Conversation

f3l1x98
Copy link
Contributor

@f3l1x98 f3l1x98 commented Sep 25, 2023 •
edited
Loading

Part of #430

Refactored test logger cache as described in #432 (review)

georg-schwarz
georg-schwarz reviewed Sep 26, 2023
View reviewed changes
Copy link
Member

@georg-schwarz georg-schwarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you please move it out of the test project and call it CachedLogger or so? I think we will need this elsewhere as well.

@f3l1x98
- Moved TestLogger from test to lib and renamed to CachedLogger
90b7cb0 
- Added 'cacheSize' parameter to CachedLogger constructor
@f3l1x98 f3l1x98 merged commit 4a40a97 into main Oct 16, 2023
2 checks passed
@f3l1x98 f3l1x98 deleted the feature/test-logger-cache-refactor branch October 16, 2023 10:30
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@georg-schwarz georg-schwarz georg-schwarz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@f3l1x98 @georg-schwarz