Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Publish and Use: Elements and Libraries #476
[RFC] Publish and Use: Elements and Libraries #476
Changes from 5 commits
b2b734f
1ba5b87
54aa967
ba94e0b
5d7e9c8
2d0e9e4
db434a8
1e8d165
f62b807
86d97bb
e71dea2
96c241d
185ae1e
a06ca37
df7e5a4
67c8344
4110a4b
a628fed
0837c79
18ad295
a230d63
b578fef
f12e3fa
cb8b061
5758e8b
3404302
32d31a8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We kind of defaulted to this (I assume from TypeScript experience) but I actually agree. Why have bracers? I would remove them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the braces.
Without it seems like some default exports (as a TS/JS-influenced dev) or different statements (
int a = 0, b = 1
). Braces clarify this imo.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a visual perspective, I also like the braces. Without braces, I'm unsure how very long
use
statements would be split into separate lines.