Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC 0016 instances vs types #531

Merged
merged 10 commits into from
Mar 1, 2024
Merged

RFC 0016 instances vs types #531

merged 10 commits into from
Mar 1, 2024

Conversation

rhazn
Copy link
Contributor

@rhazn rhazn commented Feb 16, 2024

Continuing the discussion from #485.

@rhazn rhazn self-assigned this Feb 16, 2024
Copy link
Member

@georg-schwarz georg-schwarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few nitpicky comments. Overall, the RFC captures our intended changes very well I think.

Copy link
Contributor

@joluj joluj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two pedantic suggestions. I don't expect them to be changed, they are not worth a commit unless you change something else anyway.


## Alternatives
- Introduce explicit execution calls like `pipeline.execute();` or `instantiate <pipeline name>;`/`run <pipeline name>;` instead of implicitly executing pipelines
- Decided against because Jayvee is purely descriptive right now outside of expressions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could go with calling it declarative. Or am I misinterpreting something here? https://en.wikipedia.org/wiki/Comparison_of_programming_paradigms

Suggested change
- Decided against because Jayvee is purely descriptive right now outside of expressions
- Decided against because Jayvee is purely declarative right now outside of expressions

-->

## Summary
Following the [Design Principles](https://jvalue.github.io/jayvee/docs/dev/design-principles), Jayvee focuses on describing a goal state instead of how to get there. When creating pipelines, programmers use the pipe syntax `->` to connect previously defined `blocks`. Implicitely, the interpreter creates unnamed singleton instances of those blocks and executes them.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Following the [Design Principles](https://jvalue.github.io/jayvee/docs/dev/design-principles), Jayvee focuses on describing a goal state instead of how to get there. When creating pipelines, programmers use the pipe syntax `->` to connect previously defined `blocks`. Implicitely, the interpreter creates unnamed singleton instances of those blocks and executes them.
Following our [Design Principles](https://jvalue.github.io/jayvee/docs/dev/design-principles), Jayvee focuses on describing a goal state instead of how to get there. When creating pipelines, programmers use the pipe syntax `->` to connect previously defined `blocks`. Implicitely, the interpreter creates unnamed singleton instances of those blocks and executes them.

@rhazn rhazn merged commit c4d1e0c into main Mar 1, 2024
3 checks passed
@rhazn rhazn deleted the rfc-0016-instances-vs-types branch March 1, 2024 10:24
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants