-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Pprof and Superisor metrics in standalone mode #10576
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
brandond
approved these changes
Jul 25, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10576 +/- ##
==========================================
- Coverage 49.37% 43.34% -6.04%
==========================================
Files 179 179
Lines 14950 14956 +6
==========================================
- Hits 7382 6482 -900
- Misses 6207 7275 +1068
+ Partials 1361 1199 -162
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vitorsavian
approved these changes
Jul 26, 2024
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Aug 5, 2024
* Allow pprof to run on server with `--disable-agent` * Allow supervisor metrics to run on server with `--disable-agent` Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Aug 5, 2024
* Allow pprof to run on server with `--disable-agent` * Allow supervisor metrics to run on server with `--disable-agent` Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Aug 5, 2024
* Allow pprof to run on server with `--disable-agent` * Allow supervisor metrics to run on server with `--disable-agent` Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Aug 5, 2024
* Allow pprof to run on server with `--disable-agent` * Allow supervisor metrics to run on server with `--disable-agent` Signed-off-by: Derek Nola <derek.nola@suse.com>
This was referenced Aug 5, 2024
dereknola
added a commit
that referenced
this pull request
Aug 6, 2024
* Allow pprof to run on server with `--disable-agent` * Allow supervisor metrics to run on server with `--disable-agent` Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
that referenced
this pull request
Aug 6, 2024
* Allow pprof to run on server with `--disable-agent` * Allow supervisor metrics to run on server with `--disable-agent` Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
that referenced
this pull request
Aug 6, 2024
* Allow pprof to run on server with `--disable-agent` * Allow supervisor metrics to run on server with `--disable-agent` Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
that referenced
this pull request
Aug 6, 2024
* Allow pprof to run on server with `--disable-agent` * Allow supervisor metrics to run on server with `--disable-agent` Signed-off-by: Derek Nola <derek.nola@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Types of Changes
Bug fix
Verification
--disable-agent --enable-pprof
kubectl proxy
go tool pprof -top https://localhost:8001/debug/pprof/profile
Testing
Manually tested
Linked Issues
#10582
User-Facing Change
Further Comments