Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Pprof and Superisor metrics in standalone mode #10576

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

dereknola
Copy link
Contributor

@dereknola dereknola commented Jul 25, 2024

Proposed Changes

  • Allow pprof and supervisor metrics to run on servers with agent components disabled

Types of Changes

Bug fix

Verification

  • Run K3s server with --disable-agent --enable-pprof
  • Launch a kubectl proxy instance kubectl proxy
  • Access the pprof profile go tool pprof -top https://localhost:8001/debug/pprof/profile

Testing

Manually tested

Linked Issues

#10582

User-Facing Change


Further Comments

Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola requested a review from a team as a code owner July 25, 2024 21:45
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 43.34%. Comparing base (d4c3422) to head (e87de93).
Report is 1 commits behind head on master.

Files Patch % Lines
pkg/agent/run.go 0.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10576      +/-   ##
==========================================
- Coverage   49.37%   43.34%   -6.04%     
==========================================
  Files         179      179              
  Lines       14950    14956       +6     
==========================================
- Hits         7382     6482     -900     
- Misses       6207     7275    +1068     
+ Partials     1361     1199     -162     
Flag Coverage Δ
e2etests 36.28% <0.00%> (-9.81%) ⬇️
inttests 19.69% <0.00%> (-17.02%) ⬇️
unittests 13.39% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola merged commit a70157c into k3s-io:master Jul 26, 2024
29 checks passed
@dereknola dereknola deleted the pprof_standalone branch July 29, 2024 16:53
dereknola added a commit to dereknola/k3s that referenced this pull request Aug 5, 2024
* Allow pprof to run on server with `--disable-agent`
* Allow supervisor metrics to run on server with `--disable-agent`

Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit to dereknola/k3s that referenced this pull request Aug 5, 2024
* Allow pprof to run on server with `--disable-agent`
* Allow supervisor metrics to run on server with `--disable-agent`

Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit to dereknola/k3s that referenced this pull request Aug 5, 2024
* Allow pprof to run on server with `--disable-agent`
* Allow supervisor metrics to run on server with `--disable-agent`

Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit to dereknola/k3s that referenced this pull request Aug 5, 2024
* Allow pprof to run on server with `--disable-agent`
* Allow supervisor metrics to run on server with `--disable-agent`

Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit that referenced this pull request Aug 6, 2024
* Allow pprof to run on server with `--disable-agent`
* Allow supervisor metrics to run on server with `--disable-agent`

Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit that referenced this pull request Aug 6, 2024
* Allow pprof to run on server with `--disable-agent`
* Allow supervisor metrics to run on server with `--disable-agent`

Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit that referenced this pull request Aug 6, 2024
* Allow pprof to run on server with `--disable-agent`
* Allow supervisor metrics to run on server with `--disable-agent`

Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit that referenced this pull request Aug 6, 2024
* Allow pprof to run on server with `--disable-agent`
* Allow supervisor metrics to run on server with `--disable-agent`

Signed-off-by: Derek Nola <derek.nola@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants