Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rotateca validation failures when not touching default self-signed CAs #10710

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

brandond
Copy link
Contributor

Proposed Changes

Fix rotateca validation failures when not touching default self-signed CAs

Also silences warnings about bootstrap fields that are not intended to be handled by CA rotation

Types of Changes

bugfix

Verification

See linked issue

Testing

Linked Issues

User-Facing Change


Further Comments

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 8.69565% with 21 lines in your changes missing coverage. Please review.

Project coverage is 42.90%. Comparing base (649678b) to head (6b38d34).
Report is 11 commits behind head on master.

Files Patch % Lines
pkg/server/cert.go 0.00% 20 Missing ⚠️
pkg/bootstrap/bootstrap.go 66.66% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (649678b) and HEAD (6b38d34). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (649678b) HEAD (6b38d34)
inttests 10 9
e2etests 7 5
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10710      +/-   ##
==========================================
- Coverage   49.58%   42.90%   -6.69%     
==========================================
  Files         179      179              
  Lines       14979    14992      +13     
==========================================
- Hits         7428     6432     -996     
- Misses       6187     7394    +1207     
+ Partials     1364     1166     -198     
Flag Coverage Δ
e2etests 36.21% <8.69%> (-10.09%) ⬇️
inttests 36.03% <8.69%> (-0.66%) ⬇️
unittests 13.37% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…d CAs

Also silences warnings about bootstrap fields that are not intended to be handled by CA rotation

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants