Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover edge case when on new minor release for E2E upgrade test #10781

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

dereknola
Copy link
Contributor

Proposed Changes

When a new minor is being developed, there is not yet a new release channel to pull from for the Upgrade test. Fallback to "latest"

Types of Changes

CI Fix

Verification

Manual tested with release-1.31 (which currently does not have a release)

Testing

Linked Issues

N/A

User-Facing Change


Further Comments

Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola requested a review from a team as a code owner August 29, 2024 22:58
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.89%. Comparing base (85e02e1) to head (ff385aa).
Report is 5 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (85e02e1) and HEAD (ff385aa). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (85e02e1) HEAD (ff385aa)
e2etests 7 6
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10781      +/-   ##
==========================================
- Coverage   49.59%   43.89%   -5.71%     
==========================================
  Files         178      178              
  Lines       14753    14753              
==========================================
- Hits         7317     6476     -841     
- Misses       6091     7089     +998     
+ Partials     1345     1188     -157     
Flag Coverage Δ
e2etests 36.19% <ø> (-9.67%) ⬇️
inttests 36.76% <ø> (+17.02%) ⬆️
unittests 13.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola
Copy link
Contributor Author

/trivy

Copy link
Contributor

github-actions bot commented Aug 30, 2024


bin/k3s (gobinary)
==================
Total: 1 (HIGH: 1, CRITICAL: 0)

┌──────────────────────────────────────────────────────────────┬────────────────┬──────────┬────────┬───────────────────┬───────────────┬─────────────────────────────────────────────────────────────┐
│                           Library                            │ Vulnerability  │ Severity │ Status │ Installed Version │ Fixed Version │                            Title                            │
├──────────────────────────────────────────────────────────────┼────────────────┼──────────┼────────┼───────────────────┼───────────────┼─────────────────────────────────────────────────────────────┤
│ go.opentelemetry.io/contrib/instrumentation/google.golang.o- │ CVE-2023-47108 │ HIGH     │ fixed  │ v0.45.0           │ 0.46.0        │ opentelemetry-go-contrib: DoS vulnerability in otelgrpc due │
│ rg/grpc/otelgrpc                                             │                │          │        │                   │               │ to unbound cardinality metrics                              │
│                                                              │                │          │        │                   │               │ https://avd.aquasec.com/nvd/cve-2023-47108                  │
└──────────────────────────────────────────────────────────────┴────────────────┴──────────┴────────┴───────────────────┴───────────────┴─────────────────────────────────────────────────────────────┘

bin/runc (gobinary)
===================
Total: 1 (HIGH: 1, CRITICAL: 0)

┌──────────────────┬────────────────┬──────────┬────────┬───────────────────┬───────────────┬──────────────────────────────────────────────────────────────┐
│     Library      │ Vulnerability  │ Severity │ Status │ Installed Version │ Fixed Version │                            Title                             │
├──────────────────┼────────────────┼──────────┼────────┼───────────────────┼───────────────┼──────────────────────────────────────────────────────────────┤
│ golang.org/x/net │ CVE-2023-39325 │ HIGH     │ fixed  │ v0.8.0            │ 0.17.0        │ golang: net/http, x/net/http2: rapid stream resets can cause │
│                  │                │          │        │                   │               │ excessive work (CVE-2023-44487)                              │
│                  │                │          │        │                   │               │ https://avd.aquasec.com/nvd/cve-2023-39325                   │
└──────────────────┴────────────────┴──────────┴────────┴───────────────────┴───────────────┴──────────────────────────────────────────────────────────────┘

@dereknola dereknola merged commit 254c16f into k3s-io:master Sep 3, 2024
29 checks passed
@dereknola dereknola deleted the fix_upgrade_channel branch September 3, 2024 16:58
dereknola added a commit to dereknola/k3s that referenced this pull request Sep 3, 2024
dereknola added a commit to dereknola/k3s that referenced this pull request Sep 3, 2024
dereknola added a commit to dereknola/k3s that referenced this pull request Sep 3, 2024
dereknola added a commit to dereknola/k3s that referenced this pull request Sep 3, 2024
dereknola added a commit that referenced this pull request Sep 4, 2024
Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit that referenced this pull request Sep 4, 2024
Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit that referenced this pull request Sep 4, 2024
Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit to dereknola/k3s that referenced this pull request Sep 6, 2024
dereknola added a commit that referenced this pull request Sep 6, 2024
Signed-off-by: Derek Nola <derek.nola@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants