Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider a depressolver implemented against the interface #908

Closed
kuritka opened this issue Jun 20, 2022 · 0 comments · Fixed by #910
Closed

Consider a depressolver implemented against the interface #908

kuritka opened this issue Jun 20, 2022 · 0 comments · Fixed by #910

Comments

@kuritka
Copy link
Collaborator

kuritka commented Jun 20, 2022 •
edited
Loading

I've been considering implementing a depressolver against the interface for a long time - mainly because of the generated mocks, which would make testing the GSLB controller much easier. Practice says that you shouldn't change the implementation for testing, but it would be more than appropriate at this point.

if accept the new interface, implement the following steps:

  • the implementation of the Resolver interface
  • refactor
  • modify the tests if necessary
  • generate MOCK
kuritka added a commit that referenced this issue Jun 21, 2022
@kuritka
Extract depresolver interface
93a6609 
close #908

- extracting interface GslbResolver tight with gslb
- GslbResolver Mock
- refactor Reconciler

Signed-off-by: kuritka <kuritka@gmail.com>
kuritka added a commit that referenced this issue Jun 21, 2022
@kuritka
Extract depresolver interface
46bd1d0 
close #908

- extracting interface GslbResolver
- GslbResolver Mock
- refactor Reconciler

Signed-off-by: kuritka <kuritka@gmail.com>
@kuritka kuritka mentioned this issue Jun 21, 2022
Closed
kuritka added a commit that referenced this issue Jun 21, 2022
@kuritka
Extract depresolver interface
46a6b87 
close #908

- extracting interface GslbResolver
- GslbResolver Mock
- refactor Reconciler

Signed-off-by: kuritka <kuritka@gmail.com>
kuritka added a commit that referenced this issue Jun 21, 2022
@kuritka
Extract depresolver interface
def03b3 
close #908

- extracting interface GslbResolver
- GslbResolver Mock
- refactor Reconciler

Signed-off-by: kuritka <kuritka@gmail.com>
kuritka added a commit that referenced this issue Jun 21, 2022
@kuritka
Extract depresolver interface
869e31e 
close #908

- extracting interface GslbResolver
- GslbResolver Mock
- refactor Reconciler

Signed-off-by: kuritka <kuritka@gmail.com>
@kuritka kuritka mentioned this issue Jun 21, 2022
Merged
kuritka added a commit that referenced this issue Jun 21, 2022
@kuritka
Extract depresolver interface
fbcb89b 
close #908

- extracting interface GslbResolver
- GslbResolver Mock
- refactor Reconciler

Signed-off-by: kuritka <kuritka@gmail.com>
kuritka added a commit that referenced this issue Jun 21, 2022
@kuritka
Extract depresolver interface (#910)
010bb90 
close #908

- extracting interface GslbResolver
- GslbResolver Mock
- refactor Reconciler

Signed-off-by: kuritka <kuritka@gmail.com>
kuritka added a commit that referenced this issue Jun 22, 2022
@kuritka
annotation
1df9cfc 
Test no.1

calling Do

weight annotation test

123

test- fails on depresolver blocker

Validation for strategy type (#906)

Strategies are not validated. I am adding validation to the strategy type.

Signed-off-by: kuritka <kuritka@gmail.com>

Extract depresolver interface

close #908

- extracting interface GslbResolver
- GslbResolver Mock
- refactor Reconciler

Signed-off-by: kuritka <kuritka@gmail.com>

update test

Extract depresolver interface (#910)

close #908

- extracting interface GslbResolver
- GslbResolver Mock
- refactor Reconciler

Signed-off-by: kuritka <kuritka@gmail.com>

Weight Round Robin - annotations

tests passing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extract depresolver interface k8gb-io/k8gb
Extract depresolver interface k8gb-io/k8gb
1 participant
@kuritka