Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to enable custom coredns plugins #1248

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Allow to enable custom coredns plugins #1248

merged 2 commits into from
Aug 31, 2023

Conversation

kuritka
Copy link
Collaborator

@kuritka kuritka commented Aug 30, 2023

Build on the top of @k0da #1244

This allows to add more plugins to k8gb controlled CoreDNS configmap

Like

k8gb:
  coredns:
    extra_plugins:
      log

..

HOW TO RUN CI ---

By default, all the checks will be run automatically. Furthermore, when changing website-related stuff, the preview will be generated by the netlify bot.

Heavy tests

Add the heavy-tests label on this PR if you want full-blown tests that include more than 2-cluster scenarios.

Debug tests

If the test suite is failing for you, you may want to try triggering Re-run all jobs (top right) with debug logging enabled. It will also make the print debug action more verbose.

k0da and others added 2 commits August 27, 2023 21:53
This allows to add more plugins to k8gb controlled CoreDNS configmap

Like
```yaml
k8gb:
  coredns:
    extra_plugins:
      log
```

Signed-off-by: Dinar Valeev <k0da@opensuse.org>
Signed-off-by: Michal Kuritka <kuritka@gmail.com>
Copy link
Collaborator

@k0da k0da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looks great!

@k0da k0da merged commit 1bccdf3 into master Aug 31, 2023
20 checks passed
@k0da k0da deleted the pr/1244 branch August 31, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants