Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Extra plugins from object to string #1266

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Conversation

kuritka
Copy link
Collaborator

@kuritka kuritka commented Sep 11, 2023

I need to change the schema from object to string.

fir the values.yamlconfiguration:

before:

  coredns:
    extra_plugins: {log}
cloud.example.com:5353 {
    errors
    health
    log: {}
    prometheus 0.0.0.0:9153
    forward . /etc/resolv.conf
    k8s_crd {
        filter k8gb.absa.oss/dnstype=local
        negttl 300
        loadbalance weight
    }

after:

  coredns: 
    extra_plugins: |-
       log
cloud.example.com:5353 {
    errors
    health
    log 
    prometheus 0.0.0.0:9153
    forward . /etc/resolv.conf
    k8s_crd {
        filter k8gb.absa.oss/dnstype=local
        negttl 300
        loadbalance weight
    }

Signed-off-by: Michal Kuritka <kuritka@gmail.com>
Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@kuritka kuritka merged commit f17e9ea into master Sep 11, 2023
20 checks passed
@kuritka kuritka deleted the fix-extra_plugins branch September 11, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants