Bump ControllerGen, CRD #1598
Merged
Bump ControllerGen, CRD #1598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuritka
requested review from
donovanmuller,
k0da,
ytsarev and
jkremser
as code owners
|
@k0da CRD change, I would appreciate extra pair of eyes in review here, thanks :) |
|
@kuritka do we really need to change CRD? |
|
@k0da , good question. Not IMO although upgrade tests pass. Curretly CRD is ochanged by controller-gen (in our case automatically when |
Signed-off-by: Michal Kuritka <kuritka@gmail.com>
ytsarev
reviewed
Jun 14, 2024
| @@ -77,26 +83,31 @@ spec: | |||
| - kind | |||
| - name | |||
| type: object | |||
| x-kubernetes-map-type: atomic | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Applicable to maps. atomic means that the map can only be entirely replaced by a single manager. granular means that the map supports separate managers updating individual fields.
Looks matching our case
ytsarev
approved these changes
Jun 14, 2024
| kind: "" | ||
| plural: "" | ||
| conditions: [] | ||
| storedVersions: [] |
There was a problem hiding this comment.
looks like a fix for kubernetes-sigs/controller-tools#456 , good to proceed 👍
| @@ -77,26 +83,31 @@ spec: | |||
| - kind | |||
| - name | |||
| type: object | |||
| x-kubernetes-map-type: atomic | |||
There was a problem hiding this comment.
Applicable to maps. atomic means that the map can only be entirely replaced by a single manager. granular means that the map supports separate managers updating individual fields.
Looks matching our case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm upgrading the kube-linter to the latest version. I need to do this before I bump the depenencies in the go.mod files. This change modifies the CRD!
..
HOW TO RUN CI
---By default, all the checks will be run automatically. Furthermore, when changing website-related stuff, the preview will be generated by the netlify bot.
Heavy tests
Add the
heavy-testslabel on this PR if you want full-blown tests that include more than 2-cluster scenarios.Debug tests
If the test suite is failing for you, you may want to try triggering
Re-run all jobs(top right) with debug logging enabled. It will also make the print debug action more verbose.