GO 1.17 migration #838
Merged
GO 1.17 migration #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `zz_generated.deepcopy.go` was modified by us because we have different versions of GO and contains two tags, one for generating GO <1.16 `//+build`, one for generating GO >= 1.17 `//go:build`. I am removing the `GO1.16` tag. - Bump GO version in *.mod files. Because in Go 1.17 the module graph has been changed to enable pruning and lazy loading. The `go mod tidy` adds second require block contains indirect dependencies. see: https://go.dev/doc/go1.17#go-command - _Because the number of explicit requirements may be substantially larger in an expanded Go 1.17 go.mod file, the newly-added requirements on indirect dependencies in a go 1.17 module are maintained in a separate require block from the block containing direct dependencies._ - _[...] If a module specifies go 1.17 or higher in its go.mod file, its go.mod file now contains an explicit require directive for every module that provides a transitively-imported package. (In previous versions, the go.mod file typically only included explicit requirements for directly-imported packages.)_ - _If a module specifies go 1.17 or higher, the module graph includes only the immediate dependencies of other go 1.17 modules, not their full transitive dependencies. [...]_ - Build pipes runs on GO 1.17.6 as it is supported by [github virtual environment](https://go.dev/doc/go1.17#go-command) one thing is what version of GO you have installed, another is what version you have in GOROOT and finally it is about what version your IDE runs. - You make sure you use GO1.17 by default ```shell go version ``` - Check `$GOROOT` to be sure. - Check what version your IDE is using: For example, in GoLand click on `GoLand menu ->Preferences -> Go -> choose $GOROOT dropdown` Signed-off-by: kuritka <kuritka@gmail.com>
kuritka
requested review from
donovanmuller,
jkremser,
k0da,
somaritane and
ytsarev
as code owners
|
✔️ Deploy Preview for k8gb-preview ready! 🔨 Explore the source changes: 4ebbbbe 🔍 Inspect the deploy log: https://app.netlify.com/sites/k8gb-preview/deploys/61ead3692ea3f000080942d1 😎 Browse the preview: https://deploy-preview-838--k8gb-preview.netlify.app/docs/local |
somaritane
approved these changes
Jan 21, 2022
ytsarev
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zz_generated.deepcopy.gowas modified by us because we have different versions of GOand contains two tags, one for generating GO <1.16
//+build, one for generating GO >= 1.17//go:build.I am removing the
GO1.16tag.Bump GO version in *.mod files.
Because in Go 1.17 the module graph has been changed to enable pruning and lazy loading. The
go mod tidyadds secondrequire block contains indirect dependencies. see: https://go.dev/doc/go1.17#go-command
Build pipes runs on GO 1.17.6 as it is supported by github virtual environment
one thing is what version of GO you have installed, another is what version you have in GOROOT and finally it is about what version your IDE runs.
Check
$GOROOTto be sure it's 1.17Check what version your IDE is using:
For example, in GoLand click on
GoLand menu ->Preferences -> Go -> choose $GOROOT dropdownSigned-off-by: kuritka kuritka@gmail.com