Resource Extensions added #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuritka
requested review from
donovanmuller,
k0da,
somaritane,
ytsarev and
jkremser
as code owners
kuritka
force-pushed
the
sync2
branch
2 times, most recently
from
c794133
to
cd2d0df
Compare
kuritka
force-pushed
the
sync2
branch
21 times, most recently
from
3d71e25
to
affc6c8
Compare
I expanded the terratest abstraction to have easier access to resources like DNSEndpoint, or GSLB.
This way I can, for example, compare the targets in DNSEndpoints with the expected values, so
we can thus simplify code execution and avoid possible racing.
see canges in `TestWeightsExistsInLocalDNSEndpoint`.
I can do:
- easily work with External and Local DNS Endpoints, could reapply by ingress resource
- `instanceUS.ReapplyIngress(<ingress path>)`
- `instanceEU.Resources().GetExternalDNSEndpoint().GetEndpointByName(endpointDNSNameEU)`
- `instanceEU.Resources().GetLocalDNSEndpoint().GetEndpointByName(host)`
- `instanceEU.Resources().Ingress()`
- `instanceEU.Resources().GslbSpecProperty("spec.ingress.rules[0].host")`
I also added a new waiting function using Ticker:
- instanceUS.WaitForLocalDNSEndpointHasTargets(expectedTargets)
Signed-off-by: kuritka <kuritka@gmail.com>
WaitForExternalDNSEndpointExists, WaitForLocalDNSEndpointExists
waiting...
continueIfNotFound
test x1
Signed-off-by: kuritka <kuritka@gmail.com>
somaritane
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I extended the terratest abstraction to have easier access to resources like DNSEndpoint, or GSLB. This way I can, for example, compare the targets in DNSEndpoints with the expected values, so we can thus simplify code execution and avoid possible racing.
see canges in
TestWeightsExistsInLocalDNSEndpoint.I can do:
instanceUS.ReapplyIngress(<ingress path>)instanceEU.WaitForExternalDNSEndpointExists()instanceEU.WaitForLocalDNSEndpointExists()instanceEU.Resources().GetExternalDNSEndpoint().GetEndpointByName(endpointDNSNameEU)instanceEU.Resources().GetLocalDNSEndpoint().GetEndpointByName(host)instanceEU.Resources().Ingress()instanceEU.Resources().GslbSpecProperty("spec.ingress.rules[0].host")I also added a new waiting function using
Tickerclass:instanceUS.WaitForLocalDNSEndpointHasTargets(expectedTargets)Signed-off-by: kuritka kuritka@gmail.com