Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update network-attachment-definition-client to v1.4.0 #984

Merged

Conversation

ykulazhenkov
Copy link
Contributor

Update network-attachment-definition-client package to support DeviceInfo spec 1.1.0

Related PRs:
k8snetworkplumbingwg/network-attachment-definition-client#49
k8snetworkplumbingwg/device-info-spec#3

network-attachment-definition-client v1.4.0 content: https://github.com/k8snetworkplumbingwg/network-attachment-definition-client/releases/tag/v1.4.0

@coveralls
Copy link

coveralls commented Dec 12, 2022

Coverage Status

Coverage remained the same at 68.729% when pulling 5f39039 on ykulazhenkov:update-net-attach-client into 971a110 on k8snetworkplumbingwg:master.

Update network-attachment-definition-client package
to support DeviceInfo spec 1.1.0

Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
Copy link
Member

@dougbtv dougbtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@s1061123 s1061123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants