Fix ticker resource leak

Signed-off-by: Martin Kennelly <martin.kennelly@intel.com>
k8snetworkplumbingwg · Apr 28, 2021 · 5de8d66 · 5de8d66
1 parent c080956
commit 5de8d66
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/test/util/netns/netns.go b/test/util/netns/netns.go
@@ -67,12 +67,14 @@ func SetPfVfLinkNetNs(pfPciAddr, netNsPath string, pollInterval time.Duration, q
 		errL = append(errL, fmt.Errorf("SetPfVfLinkNetNs(): unable to set physical function '%s' network namespace: '%s'", pfPciAddr,
 			err.Error()))
 	}
+	ticker := time.NewTicker(pollInterval)
+	defer ticker.Stop()
 
 	for {
 		select {
 		case <-quitCh:
 			return
-		case <-time.Tick(pollInterval):
+		case <-ticker.C:
 			if err := setVfNetNs(pfPciAddr, targetNetNs); err != nil {
 				//save errors for returning but continue
 				errL = append(errL, err)