Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sytemd services are not deleted #249

Open
e0ne opened this issue Feb 10, 2022 · 2 comments
Open

sytemd services are not deleted #249

e0ne opened this issue Feb 10, 2022 · 2 comments

Comments

@e0ne
Copy link
Collaborator

e0ne commented Feb 10, 2022 •
edited
Loading

Steps to reproduce:

  • deploy SriovNetworkNodePolicy CR to configure some NIC with eSwitchMode: switchdev
  • wait until policy will be applied
  • verify systemd services switchdev-configuration-*-nm are deployed
  • delete SriovNetworkNodePolicy
  • wait until policy will be deleted

Expected results:
VFs are deleted, switchdev-configuration-*-nm services and their components are deleted if there are no needed anymore

Actual results:
systemd services and their scripts are still available on the node
@adrianchiris
Copy link
Collaborator

fix should be here:

sriov-network-operator/bindata/scripts/clean-k8s-services.sh

Line 10 in 7102b79

function clean_services() {

@rollandf
Copy link
Contributor

rollandf commented Mar 7, 2022

I will take a look

rollandf added a commit to rollandf/sriov-network-operator that referenced this issue Apr 13, 2022
@rollandf
Remove switchdev scripts when uneeded
2f5ff27 
Fixes issue k8snetworkplumbingwg#249

Signed-off-by: Fred Rolland <frolland@nvidia.com>
@rollandf rollandf mentioned this issue Apr 13, 2022
Merged
rollandf added a commit to rollandf/sriov-network-operator that referenced this issue Apr 13, 2022
@rollandf
Remove switchdev scripts when uneeded
49f9765 
Fixes issue k8snetworkplumbingwg#249

Signed-off-by: Fred Rolland <frolland@nvidia.com>
rollandf added a commit to rollandf/sriov-network-operator that referenced this issue Apr 14, 2022
@rollandf
Remove switchdev scripts when uneeded
8a47768 
Fixes issue k8snetworkplumbingwg#249

Signed-off-by: Fred Rolland <frolland@nvidia.com>
SchSeba pushed a commit to SchSeba/sriov-network-operator-1 that referenced this issue Jul 28, 2022
@rollandf @SchSeba
Remove switchdev scripts when uneeded
160531b 
Fixes issue k8snetworkplumbingwg#249

Signed-off-by: Fred Rolland <frolland@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@e0ne @rollandf @adrianchiris