Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRIOV/vDPA configuration no longer works #471

Closed
lmilleri opened this issue Jul 12, 2023 · 2 comments
Closed

SRIOV/vDPA configuration no longer works #471

lmilleri opened this issue Jul 12, 2023 · 2 comments

Comments

@lmilleri
Copy link
Contributor

After a quick test, it seems to me the SRIOV/vDPA configuration on a ConnectX-6 DX card no longer works.
I suspect it's a regression introduced by of #365.
Changing the sriov_config.json path in the following files seems to sort it out:

--- a/bindata/manifests/switchdev-config/files/switchdev-configuration-after-nm.sh.yaml
+++ b/bindata/manifests/switchdev-config/files/switchdev-configuration-after-nm.sh.yaml
@@ -5,7 +5,7 @@ contents:
   inline: |
     #!/bin/bash
     set -eux
-    input="/etc/sriov_config.json"
+    input="/etc/sriov-operator/sriov_config.json"
 
     minId=-1                                                                                             
     maxId=-1
diff --git a/bindata/manifests/switchdev-config/files/switchdev-configuration-before-nm.sh.yaml b/bindata/manifests/switchdev-config/files/switchdev-configuration-before-nm.sh.yaml
index 3337b22c..32187683 100644
--- a/bindata/manifests/switchdev-config/files/switchdev-configuration-before-nm.sh.yaml
+++ b/bindata/manifests/switchdev-config/files/switchdev-configuration-before-nm.sh.yaml
@@ -5,11 +5,11 @@ contents:
   inline: |
     #!/bin/bash
     set -eux
-    input="/etc/sriov_config.json"
+    input="/etc/sriov-operator/sriov_config.json"
     UDEV_RULE_FILE='/etc/udev/rules.d/10-persistent-net.rules'
 
     if [ ! -f $input ]; then
-      echo "File /etc/sriov_config.json not exist."
+      echo "File /etc/sriov-operator/sriov_config.json not exist."
       exit
     fi

lmilleri added a commit to lmilleri/sriov-network-operator that referenced this issue Jul 12, 2023
k8snetworkplumbingwg#471

Signed-off-by: Leonardo Milleri <lmilleri@redhat.com>
@lmilleri lmilleri mentioned this issue Jul 12, 2023
lmilleri added a commit to lmilleri/sriov-network-operator that referenced this issue Jul 13, 2023
Problem: if you apply a policy with vdpa devices, no VFs are created
Solution: make sure all the references to the file sriov_config.json
are correct, since its location has changed

k8snetworkplumbingwg#471

Signed-off-by: Leonardo Milleri <lmilleri@redhat.com>
lmilleri added a commit to lmilleri/sriov-network-operator that referenced this issue Jul 18, 2023
Problem: if you apply a policy with vdpa devices, no VFs are created
Solution: make sure all the references to the file sriov_config.json
are correct, since its location has changed

k8snetworkplumbingwg#471

Signed-off-by: Leonardo Milleri <lmilleri@redhat.com>
@adrianchiris
Copy link
Collaborator

@lmilleri can this be closed ?

@lmilleri
Copy link
Contributor Author

yes thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants