Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop default creation of SriovOperatorConfig and Policy #592

Closed
5 tasks done
adrianchiris opened this issue Jan 23, 2024 · 3 comments
Closed
5 tasks done

Stop default creation of SriovOperatorConfig and Policy #592

adrianchiris opened this issue Jan 23, 2024 · 3 comments
Assignees
@adrianchiris
Labels
enhancement New feature or request

Comments

@adrianchiris
Copy link
Collaborator

adrianchiris commented Jan 23, 2024 •
edited
Loading

Summarizing what was discussed in recent community meetings:

  • Stop the creation of SriovOperatorConfig by default
  • Stop the creation of SriovPolicy by default
  • Support only one SriovOperatorConfig named "default"
  • Move ownerRef of all components the operator creates to the "default" OperatorConfig CR instead of "default" SriovPolicy CR
  • Block creation of non "default" SriovOperatorConfig CR in webhook
@adrianchiris adrianchiris added the enhancement New feature or request label Jan 23, 2024
This was referenced Feb 6, 2024
Merged
Merged
Merged
Merged
@adrianchiris
Copy link
Collaborator Author

Note on the last bullet : we already do so today

@adrianchiris adrianchiris mentioned this issue Feb 6, 2024
Merged
@zeeke
Copy link
Member

zeeke commented Feb 27, 2024

@adrianchiris can we close this? I see no other todo item left

@adrianchiris
Copy link
Collaborator Author

Yes we can.

closing as dependent PRs merged. Thx for the reviews !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adrianchiris adrianchiris

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zeeke @adrianchiris @amorenoz